fix: stop premature query calls during fields initialization

sassoftware · Nov 16, 2023 · 13840bb · 13840bb
1 parent f659b7b
commit 13840bb
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/components/QueryEditor.tsx b/src/components/QueryEditor.tsx
@@ -192,7 +192,7 @@ export class QueryEditor extends PureComponent<Props> {
       case EspObjectType.CONTINUOUS_QUERY:
         await this.setSelectedWindow(null);
       case EspObjectType.WINDOW:
-        await this.setSelectedFields([]);
+        await this.setSelectedFields(null);
       case EspObjectType.FIELD:
         break;
     }
@@ -328,11 +328,13 @@ export class QueryEditor extends PureComponent<Props> {
     }
   }
 
-  async setSelectedFields(fields: Field[]) {
-    await this.setStateWithPromise({selectedFields: fields})
+  async setSelectedFields(fields: Field[] | null) {
+    await this.setStateWithPromise({selectedFields: fields ?? []})
 
-    this.espQueryController.save();
-    this.espQueryController.execute();
+    if (fields != null) {
+      this.espQueryController.save();
+      this.espQueryController.execute();
+    }
   }
 
   private setStateWithPromise(stateDiff: {}): Promise<void> {