Skip to content

Commit

Permalink
renamed all v2 style commands to have v2 in the name w/ burnettk
Browse files Browse the repository at this point in the history
  • Loading branch information
jasquat committed Feb 14, 2024
1 parent 8e4b36f commit 46caa2b
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from connector_http.http_request_base import HttpRequestBase


class DeleteRequest(ConnectorCommand, HttpRequestBase):
class DeleteRequestV2(ConnectorCommand, HttpRequestBase):
def __init__(
self,
url: str,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from connector_http.http_request_base import HttpRequestBase


class HeadRequest(ConnectorCommand, HttpRequestBase):
class HeadRequestV2(ConnectorCommand, HttpRequestBase):
def __init__(
self,
url: str,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from connector_http.http_request_base import HttpRequestBase


class PutRequest(ConnectorCommand, HttpRequestBase):
class PutRequestV2(ConnectorCommand, HttpRequestBase):
def __init__(
self,
url: str,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
from typing import Any
from unittest.mock import patch

from connector_http.commands.delete_request import DeleteRequest
from connector_http.commands.delete_request_v2 import DeleteRequestV2


class TestDeleteRequest:
class TestDeleteRequestV2:
def test_delete_html_from_url(self) -> None:
request = DeleteRequest(url="http://example.com")
request = DeleteRequestV2(url="http://example.com")
return_html = "<html>Hey</html>"
with patch("requests.delete") as mock_request:
mock_request.return_value.status_code = 200
Expand All @@ -24,7 +24,7 @@ def test_delete_html_from_url(self) -> None:
assert len(response["spiff__logs"]) > 0

def test_delete_json_from_url(self) -> None:
request = DeleteRequest(url="http://example.com")
request = DeleteRequestV2(url="http://example.com")
return_json = {"hey": "we_return"}
with patch("requests.delete") as mock_request:
mock_request.return_value.status_code = 200
Expand All @@ -43,7 +43,7 @@ def test_delete_json_from_url(self) -> None:
assert len(response["spiff__logs"]) > 0

def test_delete_can_handle_500(self, sleepless: Any) -> None:
request = DeleteRequest(url="http://example.com")
request = DeleteRequestV2(url="http://example.com")
return_json = {"error": "we_did_error"}
with patch("requests.delete") as mock_request:
mock_request.return_value.status_code = 500
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
from typing import Any
from unittest.mock import patch

from connector_http.commands.head_request import HeadRequest
from connector_http.commands.head_request_v2 import HeadRequestV2


class TestHeadRequest:
class TestHeadRequestV2:
def test_head_html_from_url(self) -> None:
request = HeadRequest(url="http://example.com")
request = HeadRequestV2(url="http://example.com")
return_html = "<html>Hey</html>"
with patch("requests.head") as mock_request:
mock_request.return_value.status_code = 200
Expand All @@ -24,7 +24,7 @@ def test_head_html_from_url(self) -> None:
assert len(response["spiff__logs"]) > 0

def test_head_json_from_url(self) -> None:
request = HeadRequest(url="http://example.com")
request = HeadRequestV2(url="http://example.com")
return_json = {"hey": "we_return"}
with patch("requests.head") as mock_request:
mock_request.return_value.status_code = 200
Expand All @@ -42,7 +42,7 @@ def test_head_json_from_url(self) -> None:
assert len(response["spiff__logs"]) > 0

def test_head_can_handle_500(self, sleepless: Any) -> None:
request = HeadRequest(url="http://example.com", attempts=3)
request = HeadRequestV2(url="http://example.com", attempts=3)
return_json = {"error": "we_did_error"}
with patch("requests.head") as mock_request:
mock_request.return_value.status_code = 500
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
from typing import Any
from unittest.mock import patch

from connector_http.commands.put_request import PutRequest
from connector_http.commands.put_request_v2 import PutRequestV2


class TestPutRequest:
class TestPutRequestV2:
def test_put_html_from_url(self) -> None:
request = PutRequest(url="http://example.com")
request = PutRequestV2(url="http://example.com")
return_html = "<html>Hey</html>"
with patch("requests.put") as mock_request:
mock_request.return_value.status_code = 200
Expand All @@ -24,7 +24,7 @@ def test_put_html_from_url(self) -> None:
assert len(response["spiff__logs"]) > 0

def test_put_json_from_url(self) -> None:
request = PutRequest(url="http://example.com")
request = PutRequestV2(url="http://example.com")
return_json = {"hey": "we_return"}
with patch("requests.put") as mock_request:
mock_request.return_value.status_code = 200
Expand All @@ -43,7 +43,7 @@ def test_put_json_from_url(self) -> None:
assert len(response["spiff__logs"]) > 0

def test_put_can_handle_500(self, sleepless: Any) -> None:
request = PutRequest(url="http://example.com")
request = PutRequestV2(url="http://example.com")
return_json = {"error": "we_did_error"}
with patch("requests.put") as mock_request:
mock_request.return_value.status_code = 500
Expand Down

0 comments on commit 46caa2b

Please sign in to comment.