feat(typing): Add typing #432
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesnek
commented
Jan 8, 2025
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
| max_line_length = 79 | ||
| max_line_length = 140 |
Author
There was a problem hiding this comment.
ruff setup is on 140 characters, does not make sense to prevent IDE
lesnek
changed the title
lesnek
commented
Jan 8, 2025
|
|
||
| self.triggered = False | ||
| self.task_spec = task_spec | ||
| self.task_spec = task_spec if task_spec else StartTask(workflow.spec) |
Author
There was a problem hiding this comment.
Not sure about this, check by pyright/mypy introduces the possibility of task_spec being None, but in the case of None task_spec, a lot of stuff cannot properly work.
I can delete this "fix" for typing, but it is something to consider.
lesnek
commented
Jan 8, 2025
| if parent is not None: | ||
| self.parent._child_added_notify(self) | ||
| if _parent := self.parent: | ||
| _parent._child_added_notify(self) |
Author
There was a problem hiding this comment.
Fix to conform typing, to check if the self.parent method really is not None
nadzhou
reviewed
Mar 24, 2025
| def _predict(self, mask=TaskState.NOT_FINISHED_MASK): | ||
| """Predict tasks with the provided mask""" | ||
| def _predict(self, mask: int = TaskState.NOT_FINISHED_MASK) -> None: | ||
| """Predict tasks with the provided mask.""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing PR