Fix 'server_migrating' status of non-active replica #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpawar-sap
requested review from
Carthaca,
chuan137,
sumitarora2786 and
crenduchinta88
as code owners
|
I commented at https://review.opendev.org/c/openstack/manila/+/945689 |
kpawar-sap
force-pushed
the
server_migration_fix
branch
from
d2eade5 to
060cf0a
Compare
|
updated as per upstream discussion |
|
In xena the method name has an extra 's' |
Since we allow share server migration with share replica, we need to make sure correct share and snapshot instances updated to 'server_migrating' status i.e. instances belonging to share server under migration. Fixed this. Change-Id: I498700367752f2effc8c7a1e50a233579607a9fc
kpawar-sap
force-pushed
the
server_migration_fix
branch
from
060cf0a to
ade0ef8
Compare
Carthaca
approved these changes
Apr 10, 2025
chuan137
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we allow share server migration with share replica, we need to make sure correct share and snapshot instances updated to 'server_migrating' status i.e. instances belonging to share server under migration. Fixed this.
Change-Id: I498700367752f2effc8c7a1e50a233579607a9fc