[designate] Use tcpSocket check as liveness check instead of /healthcheck #7336
+34
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s10
requested review from
galkindmitrii,
fwiesel,
mutax,
kpawar-sap,
vssldmtrv,
mbrowny,
SoenkeL and
occamshatchet
as code owners
…heck Designate API /healthcheck might not to respond under heavy POST load or respond with a significant timeout. So we need a less complicated liveness check, that could be: * apache2-specific /server-status?auto endpoint * simple TCP socket check In this PR simple tcpSocket check is being used.
* Increase cpu limits for API service: it's being throttled under locust * Increase number of designate-central services, as it's a bottleneck
s10
force-pushed
the
C5384329/designate-liveness
branch
from
677cb2f
to
3089928
Compare
galkindmitrii
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designate API /healthcheck might not respond under heavy POST load or respond with a significant timeout.
So we need a less complicated liveness check, that could be:
/server-status?autoendpointIn this PR simple tcpSocket check is being used.
Additionally: