chore(kube-monitoring): use version constraint for oomkill #7052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
requested review from
auhlig,
defo89,
databus23,
jknipper,
viennaa,
richardtief and
Kuckkuck
as code owners
Kuckkuck
approved these changes
Sep 13, 2024
viennaa
reviewed
Sep 13, 2024
viennaa
reviewed
Sep 13, 2024
IvoGoman
force-pushed
the
fix/kube-monitoring/oom-exporter
branch
2 times, most recently
from
c15b879
to
520e5da
Compare
version constraints was introduced for scaleout this uses the version constraint for the other contexts as well
IvoGoman
force-pushed
the
fix/kube-monitoring/oom-exporter
branch
from
520e5da
to
b9e72d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version constraints was introduced for scaleout, this add them for the other contexts as well.
This makes sure the routing fix for
PodOOMKillwill be made available for the other clusters as well.If you feel this is to pushy, I am also fine with replacing the
appVersionwithversionand setting it to latest.