-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for Laravel 11 and 12 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…avel-11 Chore/update dependencies for laravel 11 & 12
Hi @santigarcor! I am using this package in one of my project and while migrating it to L11. Came across an issue, that this package doesn't support laravel 11 or 12. Which was just because of the missing supported version in the composer.json file. While updating phpunit was giving deprecation notice to its config file, based on their docs, I used this All the tests are running fine now and also has support for L11 & L12. |
I think you need to update the matrix because currently the test matrix is failing |
``` Problem 1 - Root composer.json requires laravel/legacy-factories ^1.3 -> satisfiable by laravel/legacy-factories[v1.3.0, ..., 1.x-dev]. - laravel/legacy-factories[v1.3.0, ..., 1.x-dev] require php ^7.3|^8.0 -> your php version (7.2.34) does not satisfy that requirement. ```
* for PHP8.0 mockery 1.3.3 is required (dependency of orchestra/testbench) * phpunit below version 9 has direct conflict with PHP8 and beyond * orchestra/testbench lowest version for PHP8 and beyond is v6.8 * and orchestra/testbench v6 does not support Laravel 6 & 7
This means Laravel 8 is no longer supported, so removed PHP7 and along with Laravel 8 support
…github-actions Chore/update version support and GitHub actions * Removes support of php7 * And with that removed support for Laravel 6, 7 & 8
…rsions Fix/use exclude for unsuported versions
@santigarcor |
@Meeshalk If you're adding support for Laaravel 11 and 12 jjust add to the matrix the version supported by those versions which is PHP >= 8.2, and "Drop" support for the others. |
fix: PHP 8.3 tests removed
You removed the wrong ones, I meant to only add support for php greater or equal than 8.2. Because this update adds the support for Laravel 11 and 12. |
@santigarcor I have added new phpunit versions which doesn't support php 7.*. So, I don't understand what you mean. Please review composer.json and let me know whats wrong? |
--migrate-configuration
flag