Bugfix/prevent loss of reference #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianchanning
pushed a commit
to mona-health/react-input-mask
that referenced
this pull request
Feb 22, 2023
See sanniassin#254 - I just didn't like the coding style
|
@MtthsB good catch - I've added this to my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request is intended to fix an insidious bug caused by a loss of reference to the input DOM element under certain circumstances.
In concreto, when the input loses focus, i.e. on blur, in response to an action which causes a re-render of the component, the input (momentarily) loses its reference: the re-render causes the ref function invoked by React.createElement to re-initialise, passing a null object on first render. At the moment, this causes both the inputRef and the forwardedRef to be set to null.
In between the first render and the second invocation of the React.createElement ref function, onBlur (and the useValue function) is called on a null inputRef, causing a crash.
A simple fix is checking for the existence of the reference returned by the ref callback.