Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test_klines.py #15

Open
wants to merge 15 commits into
base: hybrid
Choose a base branch
from
Open

Add test_klines.py #15

wants to merge 15 commits into from

Conversation

andrgit
Copy link

@andrgit andrgit commented Aug 27, 2022

Add test_klines.py

Copy link
Owner

@sann05 sann05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И еще добавь плс проверки для интервалов

integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
Copy link
Owner

@sann05 sann05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тесты хорошие, давай дальше

integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
Copy link
Owner

@sann05 sann05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А где тесты на start_time и end_time?

minutes):
klines = client.get_klines(symbol='ETH/USD_LEVERAGE',
interval=interval)
assert all(val[0] % 60000 == 0 for val in klines)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ничего не пропустил?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну тут мы проверяем что первая свеча начинается четко с минуты 00, и вторая что разница(interval) между ними то количество минут которое указывали. И что-то еще?

integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
integration_tests/rest/test_klines.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants