-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up with upstream changes #27
base: master
Are you sure you want to change the base?
Conversation
This is a header only intended to support for Web Origin security in browsers. Other clients are not required to include this header, and the current case complicates servers since it receiving 'ws://' or 'ws://' in the 'Origin' header is highly unusual. RFC 6455, Section 4.1, Client Requirements: > Additionally, if the client is a web browser, it supplies /origin/. RFC 6455, Section 4.2.1, Reading the Client's Opening Handshake: > Optionally, an |Origin| header field. This header field is sent by > all browser clients. A connection attempt lacking this header field > SHOULD NOT be interpreted as coming from a browser client.
Do not send 'Origin' header in handshake
Fixed start_link spec to include binary option on URL
very minor, init accepts binary strings
More accurate type spec for websocket_terminate, other minor cleanup
…normal code on error
websocket_terminate type overhaul
Hey @sanmiguel @jeremyong 👋 Thanks for keeping this alive! Maybe you folks can consider creating an organisation and putting your efforts together? I honestly just want to write a client for SurrealDB and face a necessity to reinvent the wheel that would be times worse compared to the client that many people already collaborated on. That sucks! So, I hope there is a chance we can have a good tool and keep building on top of it ✌️ |
No description provided.