some of lint warning fixing and code refactor for readability

app.py

@@ -70,13 +70,13 @@
     if options.sentrydsn:
         sentry_sdk.init(dsn=options.sentrydsn, integrations=[TornadoIntegration()])
     else:
-        logging.warn("Sentry dsn is not set")
+        logging.warning("Sentry dsn is not set")
 
     mongodb = None
     while not mongodb:
         try:
             mongodb = pymongo.MongoClient(options.mongouri)
-        except:
+        except Exception:
             logging.error("Cannot not connect to MongoDB")
 
     masterdb = mongodb[options.masterdb]

controllers/auth.py

@@ -25,8 +25,10 @@
 # ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import hashlib, os
-from controllers.base import *
+from controllers.base import WebBaseHandler
+from tornado.options import options
+from routes import route
+from util import get_password
 
 
 @route(r"/auth/([^/]+)")

controllers/settings.py

@@ -57,7 +57,7 @@
 from pushservices.apns import ApnsClient
 import requests
 import traceback
-from controllers.base import *
+from controllers.base import WebBaseHandler
 
 
 @route(r"/applications/([^/]+)/settings[\/]?")
@@ -126,7 +126,7 @@ def post(self, appname):
                     app["wnstokenexpiry"] = int(responsedata["expires_in"]) + int(
                         time.time()
                     )
-                    ## Update connections too
+                    # Update connections too
                     self.wnsconnections[app["shortname"]] = []
                     wns = WNSClient(self.masterdb, app, 0)
                     self.wnsconnections[app["shortname"]].append(wns)

pushservices/bootstrap.py

@@ -1,5 +1,5 @@
 import logging
-from .apns import *
+from .apns import ApnsClient
 from .clickatell import *
 from .fcm import FCMClient
 from .mpns import MPNSClient
@@ -63,9 +63,8 @@ def init_messaging_agents(masterdb):
         if "wnsclientid" in app and "wnsclientsecret" in app and "shortname" in app:
             try:
                 wns = WNSClient(masterdb, app, 0)
+                services["wns"][appname].append(wns)
             except Exception as ex:
                 logging.error(ex)
                 continue
-            services["wns"][appname].append(wns)
-
     return services