fix: broken ndjson implementation #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
requested changes
May 13, 2024
src/cli.js
Outdated
Comment on lines
108
to
119
| const value = await result.get() | ||
|
|
||
| if (Array.isArray(value)) { | ||
| for await (const row of value) { | ||
| yield JSON.stringify(row) | ||
| yield '\n' | ||
| } | ||
| } else { | ||
| yield JSON.stringify(await result.get()) | ||
| yield JSON.stringify(value) | ||
| yield '\n' | ||
| } | ||
| } |
There was a problem hiding this comment.
I think all we want to do is change L108 to if (result.type == 'stream') { that way we stream the values per document in the resulting query
The proposed solution would turn any arrays into ndjson separated list, echo '{\"foo\": [1,2,3,4]}\n{\"bar\": [2]}' | ./bin/groq.js -n --pretty '*[][0].foo' would return '1\n2\n3\n4instead of[1,2,3,4]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Was broken by e5e7e57 upgrading the major of
ndjsonwithout updating the API.