Skip to content

Y25-503 - Added retention instructions to tube manifests#5371

Merged
borhara merged 4 commits intodevelopfrom
y25-503-add-ret-tube-manifests
Dec 12, 2025
Merged

Y25-503 - Added retention instructions to tube manifests#5371
borhara merged 4 commits intodevelopfrom
y25-503-add-ret-tube-manifests

Conversation

@borhara
Copy link
Copy Markdown
Member

@borhara borhara commented Nov 21, 2025

Closes #5152

Changes proposed in this pull request

  • Added a retention_instruction column to Default Tube and Long Read manifest templates.
  • Added a test to verify retention instructions are added to the manifests.
  • Checked the retention_instruction value is populated when viewing labware.
  • Checked the retention_instruction value is populated when creating location reports.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.17%. Comparing base (17d8fb9) to head (119c29c).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5371      +/-   ##
===========================================
+ Coverage    87.11%   87.17%   +0.05%     
===========================================
  Files         1457     1457              
  Lines        32589    32589              
  Branches      3400     3400              
===========================================
+ Hits         28389    28408      +19     
+ Misses        4186     4167      -19     
  Partials        14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@borhara borhara merged commit 2e0b4ad into develop Dec 12, 2025
28 checks passed
@borhara borhara deleted the y25-503-add-ret-tube-manifests branch December 12, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-503 - Add retention instructions to tube manifests

2 participants