Y25-586 - Part 2 - Ultima AMP plate layout verification #5349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e layout verification but with different format barcodes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5349 +/- ##
===========================================
- Coverage 87.13% 87.13% -0.01%
===========================================
Files 1452 1452
Lines 32404 32436 +32
Branches 3382 3386 +4
===========================================
+ Hits 28236 28263 +27
- Misses 4154 4159 +5
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ameter to distinguish between tubes and AMP plates - neater
…s probably a bit off.
…eneralise success message
yoldas
approved these changes
Nov 28, 2025
| <%= page_title "Verify #{@verification_flavour.to_s.humanize} Layout", "Batch #{@batch.id}" %> | ||
| <div class="info"> | ||
| Please scan the barcodes from the sample tubes into the table below. | ||
| <%= "Please scan the barcodes from the #{@verification_flavour.to_s.humanize.downcase.pluralize} into the table below." %> |
Member
There was a problem hiding this comment.
note: AMQ will be lowercase in ... from the amq plates into the ... , but OK.
Contributor
Author
There was a problem hiding this comment.
Yes I know... was hoping it wasn't too important 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5272
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version