Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 11, 2025

Proposed Changes

Instructions for Reviewers

  • Check stories are ready for release.
  • Check for any database migrations.
  • Check for debug code.
  • Check version is appropriate.

Everything above the horizontal rule will be overwritten on the next push
This PR was auto-generated on 2025-11-28T10:03:59+00:00


Additional Context

Notes to include in release email:

  • Fix for taxonomy lookup when editing samples
  • Behind the scenes tweaks to accessioning

KatyTaylor and others added 13 commits November 6, 2025 10:33
…ue to use of the form tag meaning the CSRF token doesn't get passed in the request. Also remove studies reference from label as it's not retrieving the study, and the feature wasn't requested
…ed arbitrary. Fails complexity metrics now but seems a lot more readable to me
@github-actions github-actions bot added the production release Pull requests for production release label Nov 11, 2025
yoldas and others added 4 commits November 11, 2025 14:38
…ncescape-to-generate-a-sample-sheet-to-load-into-the-ultima-ug-1000-sequencer-so-that-we-can-run-it
Y25-480 - Enable Gatekeeper lot registration via V2 API
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 85.19231% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (2d19a31) to head (0de8033).
⚠️ Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
app/models/accession_service/base_service.rb 71.87% 36 Missing ⚠️
app/jobs/sample_accessioning_job.rb 82.00% 8 Missing and 1 partial ⚠️
app/controllers/batches_controller.rb 33.33% 6 Missing ⚠️
app/controllers/studies/information_controller.rb 0.00% 6 Missing ⚠️
app/controllers/qc_reports_controller.rb 0.00% 3 Missing ⚠️
app/controllers/plate_summaries_controller.rb 0.00% 2 Missing ⚠️
app/controllers/sdb/sample_manifests_controller.rb 0.00% 2 Missing ⚠️
app/models/accession_service/ena_service.rb 71.42% 2 Missing ⚠️
app/models/accessionable/base.rb 0.00% 2 Missing ⚠️
app/resources/api/v2/lot_resource.rb 80.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5347      +/-   ##
==========================================
+ Coverage   87.01%   87.14%   +0.12%     
==========================================
  Files        1445     1454       +9     
  Lines       32169    32478     +309     
  Branches     3372     3395      +23     
==========================================
+ Hits        27993    28303     +310     
+ Misses       4163     4161       -2     
- Partials       13       14       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

StephenHulme and others added 30 commits November 26, 2025 12:44
…-2.32.0

[ruby] Update rubocop-rspec_rails 2.31.0 → 2.32.0 (minor)
…-2.28.0

[ruby] Update rubocop-factory_bot 2.27.1 → 2.28.0 (minor)
Y25-286 - Refactor accessioning classes
[js] Update terser 5.44.0 → 5.44.1 (patch)
….1.1

[ruby] Update faraday-multipart 1.0.4 → 1.1.1 (minor)
[ruby] Update mocha 2.7.1 → 2.8.2 (minor)
[ruby] Update minitest 5.26.0 → 5.26.1 (patch)
[ruby] Update bootsnap 1.18.6 → 1.19.0 (minor)
[ruby] Update rubocop-rails 2.33.4 → 2.34.1 (minor)
[ruby] Update whenever 1.0.0 → 1.1.0 (minor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

production release Pull requests for production release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants