Skip to content

Conversation

@dasunpubudumal
Copy link
Contributor

@dasunpubudumal dasunpubudumal commented Oct 20, 2025

Closes #5205

Changes proposed in this pull request

  • Adding a check for the number of labwares stored in a given location.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.15%. Comparing base (9f434e8) to head (fb27c8d).
⚠️ Report is 71 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/location_report.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5299      +/-   ##
===========================================
+ Coverage    87.06%   87.15%   +0.08%     
===========================================
  Files         1447     1452       +5     
  Lines        32289    32544     +255     
  Branches      3375     3413      +38     
===========================================
+ Hits         28114    28364     +250     
- Misses        4162     4167       +5     
  Partials        13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dasunpubudumal dasunpubudumal marked this pull request as ready for review November 24, 2025 09:31
Copy link
Member

@andrewsparkes andrewsparkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking about the limit number. Else looks good.

def search_for_labware_by_selection
params = { faculty_sponsor_ids:, study_id:, start_date:, end_date:, plate_purpose_ids:, barcodes: }
count = Labware.search_for_count_of_labware(params)
if count > configatron.fetch(:location_reports_fetch_count_max, 500)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 500 a number discussed with the users?
I would think, as an example, that a standard -80 freezer will hold significantly more than 500 labwares.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe find out what location(s) they typically want a report on and check the counts in those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants