Skip to content

Conversation

@StephenHulme
Copy link
Contributor

@StephenHulme StephenHulme commented Aug 5, 2025

Solves 500 error on https://psd-team.slack.com/archives/C01J32MB747/p1754385779757759

Changes proposed in this pull request

  • Truncate long flash messages from accessioning

Additional context

Debug logs

Test by visiting https://training.sequencescape.psd.sanger.ac.uk/samples/10189662 after 10 August and clicking Generate Accession Number

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme self-assigned this Aug 5, 2025
@StephenHulme StephenHulme added the Bug Bug in code label Aug 5, 2025
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.96%. Comparing base (3c9e6a9) to head (79b8c90).
⚠️ Report is 435 commits behind head on develop.

Files with missing lines Patch % Lines
app/controllers/samples_controller.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5146      +/-   ##
===========================================
- Coverage    86.97%   86.96%   -0.01%     
===========================================
  Files         1437     1437              
  Lines        31810    31810              
  Branches      3313     3313              
===========================================
- Hits         27666    27665       -1     
- Misses        4131     4132       +1     
  Partials        13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme
Copy link
Contributor Author

This fix doesn't seem to resolve the issue, although the size of the cookie does decrease:

message:
Aug 5 12:25:03 sss0-training-jammy sequencescape[2447267]: (thread-173744) [14.75.3:training] ERROR -- : #012ActionDispatch::Cookies::CookieOverflow (_sequencescape_session cookie overflowed with size 4340 bytes)

message:
Aug 5 12:15:39 sss1-training-jammy sequencescape[1288813]: (thread-2651488) [14.75.1:training] ERROR -- : #012ActionDispatch::Cookies::CookieOverflow (_sequencescape_session cookie overflowed with size 8948 bytes)

@StephenHulme StephenHulme removed their assignment Sep 8, 2025
@andrewsparkes andrewsparkes added Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. Tech roadmap 2 labels Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accessioning Epic in technical roadmap June 2025, relating to improving the accessioning code. Bug Bug in code Tech roadmap 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants