feat(browser): detect Holla Web Browser (com.hollabrowser.meforce)

ref matomo-org#7039
sanchezzzhak · Nov 22, 2023 · 4f5d1cf · 4f5d1cf
1 parent 1c7512c
commit 4f5d1cf
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -256,6 +256,7 @@ class Browser extends AbstractClientParser
         'HX' => 'Hexa Web Browser',
         'HI' => 'Hi Browser',
         'HO' => 'hola! Browser',
+        'H4' => 'Holla Web Browser',
         'HJ' => 'HotJava',
         'HT' => 'HTC Browser',
         'HU' => 'Huawei Browser Mobile',
@@ -606,7 +607,7 @@ class Browser extends AbstractClientParser
             'F4', 'YG', 'WR', 'NA', 'DM', '1M', 'A7', 'XN', 'XT',
             'XB', 'W1', 'HT', 'B8', 'F5', 'B9', 'WA', 'T0', 'HC',
             'O6', 'P7', 'LJ', 'LC', 'O7', 'N2', 'A8', 'P8', 'RB',
-            '1W', 'EV', 'I9', 'V4',
+            '1W', 'EV', 'I9', 'V4', 'H4',
         ],
         'Firefox'            => [
             'AX', 'BI', 'BF', 'BH', 'BN', 'C0', 'CU', 'EI', 'F1',
@@ -645,7 +646,7 @@ class Browser extends AbstractClientParser
         'B5', 'B6', 'TC', 'A6', '2X', 'F4', 'YG', 'WR', 'NA',
         'DM', '1M', 'A7', 'XN', 'XT', 'XB', 'W1', 'HT', 'B7',
         'B9', 'T0', 'I8', 'O6', 'P7', 'O8', '4B', 'A8', 'P8',
-        '1W', 'EV', 'Z0', 'I9',
+        '1W', 'EV', 'Z0', 'I9', 'V4', 'H4',
     ];
 
     /**

diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml
@@ -7725,3 +7725,14 @@
     family: Chrome
   headers:
     http-x-requested-with: com.alohamobile.vertexsurf
+-
+  user_agent: Mozilla/5.0 (Linux; Android 11; M1908C3JGG Build/RP1A.200720.011; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/98.0.4758.101 Mobile Safari/537.36
+  client:
+    type: browser
+    name: Holla Web Browser
+    version: ""
+    engine: Blink
+    engine_version: 98.0.4758.101
+    family: Chrome
+  headers:
+    http-x-requested-with: com.hollabrowser.meforce
diff --git a/regexes/client/hints/browsers.yml b/regexes/client/hints/browsers.yml
@@ -216,3 +216,4 @@
 'nu.tommie.inbrowser': 'InBrowser'
 'com.insta.browser': 'Insta Browser'
 'com.alohamobile.vertexsurf': 'Vertex Surf'
+'com.hollabrowser.meforce': 'Holla Web Browser'