feat(client) detect browsers: Soul Browser

issue matomo-org#7039
sanchezzzhak · Mar 20, 2022 · 292dbd8 · 292dbd8
1 parent dd46ab2
commit 292dbd8
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 2 deletions.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -353,6 +353,8 @@ class Browser extends AbstractClientParser
         'S8' => 'Seewo Browser',
         'SC' => 'SEMC-Browser',
         'SE' => 'Sogou Explorer',
+        'SO' => 'Sogou Mobile Browser',
+        '2S' => 'Soul Browser',
         'SF' => 'Safari',
         'PV' => 'Safari Technology Preview',
         'S5' => 'Safe Exam Browser',
@@ -373,7 +375,6 @@ class Browser extends AbstractClientParser
         'LE' => 'Smart Lenovo Browser',
         'OZ' => 'Smooz',
         'SN' => 'Snowshoe',
-        'SO' => 'Sogou Mobile Browser',
         'B1' => 'Spectre Browser',
         'S2' => 'Splash',
         'SI' => 'Sputnik Browser',
@@ -461,7 +462,7 @@ class Browser extends AbstractClientParser
             'VG', 'VI', 'VM', 'WP', 'WH', 'XV', 'YJ', 'YN', 'FH',
             'B1', 'BO', 'HB', 'PC', 'LA', 'LT', 'PD', 'HR', 'HU',
             'HP', 'IO', 'TP', 'CJ', 'HQ', 'HI', 'NA', 'BW', 'YO',
-            'DC', 'G8',
+            'DC', 'G8', '2S',
         ],
         'Firefox'            => [
             'AX', 'BI', 'BF', 'BH', 'BN', 'C0', 'CU', 'EI', 'F1',

diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml
@@ -5092,3 +5092,41 @@
     family: Chrome
   headers:
     X-Requested-With: com.ucold.browser.secure.browse
+-
+  user_agent: Mozilla/5.0 (Linux; Android 11; M2007J3SG Build/RKQ1.200826.002; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/96.0.4664.45 Mobile Safari/537.36 SoulBrowser
+  client:
+    type: browser
+    name: Soul Browser
+    version: ""
+    engine: Blink
+    engine_version: ""
+    family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 11; M2007J3SY Build/RKQ1.200826.002) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/97.0.4692.98 Mobile Safari/537.36 Soul
+  client:
+    type: browser
+    name: Soul Browser
+    version: ""
+    engine: Blink
+    engine_version: ""
+    family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 9; Redmi Note 5 Build/PKQ1.180904.001) AppleWebKit/537.36 (KHTML, like Gecko) Soul/4.0 Chrome/96.0.4664.104 Mobile Safari/537.36
+  client:
+    type: browser
+    name: Soul Browser
+    version: ""
+    engine: Blink
+    engine_version: ""
+    family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; Android 11; M2010J19SG Build/RKQ1.201004.002; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/98.0.4758.87 Mobile Safari/537.36
+  client:
+    type: browser
+    name: Soul Browser
+    version: ""
+    engine: Blink
+    engine_version: ""
+    family: Chrome
+  headers:
+    X-Requested-With: com.mycompany.app.soulbrowser
diff --git a/regexes/client/browsers.yml b/regexes/client/browsers.yml
@@ -2001,6 +2001,13 @@
     versions:
       28: 'Blink'
 
+# Soul Browser (https://play.google.com/store/apps/details?id=com.mycompany.app.soulbrowser)
+- regex: 'Soul(?:Browser)?$|Soul/'
+  name: 'Soul Browser'
+  version: ''
+  engine:
+    default: 'Blink'
+
 # LG Browser
 - regex: 'LG Browser(?:/(\d+[\.\d]+))'
   name: 'LG Browser'

diff --git a/regexes/client/hints/browsers.yml b/regexes/client/hints/browsers.yml
@@ -45,3 +45,4 @@
 'org.lineageos.jelly': 'Jelly'
 'com.opera.gx': 'Opera GX'
 'com.ucold.browser.secure.browse': 'UC Browser Mini'
+'com.mycompany.app.soulbrowser': 'Soul Browser'