feat(client) detect browser: OH Private Browser

issue matomo-org#7039
sanchezzzhak · Mar 17, 2022 · 0cc98ba · 0cc98ba
1 parent ec586b1
commit 0cc98ba
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -53,6 +53,7 @@ class Browser extends AbstractClientParser
         '1I' => 'IE Browser Fast',
         '1V' => 'Vegas Browser',
         '1O' => 'OH Browser',
+        '3O' => 'OH Private Browser',
         '1X' => 'XBrowser Mini',
         '1S' => 'Sharkee Browser',
         '2L' => 'Lark Browser',
@@ -672,11 +673,10 @@ public function parse(): ?array
             $name    = $appHash['name'];
             $version = '';
             $short   = self::getBrowserShortName($name);
-            $family  = self::getBrowserFamily((string) $short);
 
             if (\preg_match('~Chrome/.+ Safari/537.36~i', $this->userAgent)) {
                 $engine        = 'Blink';
-                $family        = $family ?? 'Chrome';
+                $family        = self::getBrowserFamily((string) $short) ?? 'Chrome';
                 $engineVersion = '';
             }
 

diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml
@@ -4988,3 +4988,14 @@
     family: Firefox
   headers:
     X-Requested-With: org.mozilla.rocket
+-
+  user_agent: Mozilla/5.0 (Linux; Android 11; Android_Device) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/96.0.4664.92 Mobile Safari/537.36
+  client:
+    type: browser
+    name: OH Private Browser
+    version: ""
+    engine: Blink
+    engine_version: ""
+    family: Chrome
+  headers:
+    X-Requested-With: com.oh.brop
diff --git a/regexes/client/hints/browsers.yml b/regexes/client/hints/browsers.yml
@@ -16,6 +16,7 @@
 'com.internet.browser.secure': 'Internet Browser Secure'
 'acr.browser.linxy': 'Vegas Browser'
 'com.oh.bro': 'OH Browser'
+'com.oh.brop': 'OH Private Browser'
 'com.duckduckgo.mobile.android': 'DuckDuckGo Privacy Browser'
 'net.onecook.browser': 'Stargon'
 'com.mi.globalbrowser.mini': 'Mint Browser'