Escape hash in link URLs

samwilson · Aug 26, 2023 · 907a30a · 907a30a
1 parent 489db5e
commit 907a30a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/LinkRenderer.php b/src/LinkRenderer.php
@@ -30,7 +30,11 @@ public function render(Node $node, ChildNodeRendererInterface $childRenderer)
 
         $out = $childRenderer->renderNodes($node->children());
 
-        $url = \str_replace('_', '\\_', $node->getUrl());
+        $replacements = [
+            '_' => '\\_',
+            '#' => '\#',
+        ];
+        $url          = \str_replace(\array_keys($replacements), $replacements, $node->getUrl());
 
         $allowUnsafeLinks = $this->config->get('allow_unsafe_links');
         if (! $allowUnsafeLinks && RegexHelper::isLinkPotentiallyUnsafe($url)) {

diff --git a/tests/data/links.md b/tests/data/links.md
@@ -1,4 +1,4 @@
-Link with protocol: [label](https://example.org).
+Link with protocol and fragment: [label](https://example.org/lorem#ipsum).
 
 Relative link: [label](./example.html).
 

diff --git a/tests/data/links.tex b/tests/data/links.tex
@@ -1,4 +1,4 @@
-Link with protocol: label\footnote{\url{https://example.org}}.
+Link with protocol and fragment: label\footnote{\url{https://example.org/lorem\#ipsum}}.
 
 Relative link: label\footnote{\url{./example.html}}.