-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I189 institutional repository carousel #2431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - removes Bootstrap carousel due to the limitations of Bootstrap's built in functionality in favor of creating a custom carousel Ref: - notch8/palni_palci_knapsack#189
This commit removes the bootstrap carousel from the Institutional Repository homepage and replaces it with a custom slider. Bootstrap carousel functionality does not align with the functionality needed for the Institutional Repository resources slider. Ref: - notch8/palni_palci_knapsack#189
Test Results 3 files ±0 3 suites ±0 17m 17s ⏱️ -26s Results for commit 4fb0193. ± Comparison against base commit 9f98d14. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
kirkkwang
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great awesome work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: [i189] Institutional Repository Carousel
Ref:
Expected Behavior Before Changes
The carousel on the homepage of the institutional repository was buggy. Icon duplications could be seen during transitions and the layout styling was not being applied during transitions.
Video: Reported issue
Screen.Recording.2025-01-24.at.5.08.11.PM.mov
Expected Behavior After Changes
When there are six or more resources in the institutional repository, there is a slider showing six of the icons. A user can click on arrows to move the icons one place to the right or left. The icons are in a continuous loop.
Video: Corrected resource carousel
Screen.Recording.2025-01-24.at.5.20.30.PM.mov
Notes
Changes proposed in this pull request:
@samvera/hyku-code-reviewers