Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I189 institutional repository carousel #2431

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

sjproctor
Copy link
Collaborator

@sjproctor sjproctor commented Jan 25, 2025

Story: [i189] Institutional Repository Carousel

Ref:

Expected Behavior Before Changes

The carousel on the homepage of the institutional repository was buggy. Icon duplications could be seen during transitions and the layout styling was not being applied during transitions.

Video: Reported issue
Screen.Recording.2025-01-24.at.5.08.11.PM.mov

Expected Behavior After Changes

When there are six or more resources in the institutional repository, there is a slider showing six of the icons. A user can click on arrows to move the icons one place to the right or left. The icons are in a continuous loop.

Video: Corrected resource carousel
Screen.Recording.2025-01-24.at.5.20.30.PM.mov

Notes

Changes proposed in this pull request:

  • This PR removes the Bootstrap carousel since out-of-box functionality does not allow for multiple items on the screen and the workarounds were causing errors
  • This approach relies on jQuery to perform the icon transitions

@samvera/hyku-code-reviewers

This commit:
- removes Bootstrap carousel due to the limitations of Bootstrap's built
in functionality in favor of creating a custom carousel

Ref:
- notch8/palni_palci_knapsack#189
This commit removes the bootstrap carousel from the Institutional Repository
homepage and replaces it with a custom slider.

Bootstrap carousel functionality does not align with the functionality
needed for the Institutional Repository resources slider.

Ref:
- notch8/palni_palci_knapsack#189
@sjproctor sjproctor added the ignore-for-release ignore this for release notes label Jan 25, 2025
Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 17s ⏱️ -26s
2 056 tests ±0  2 000 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 083 runs  ±0  2 025 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 4fb0193. ± Comparison against base commit 9f98d14.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 8d9f7542-ff73-4fd7-b1c5-5f20baea919c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 03ea5077-2ab1-46fd-be8b-6a2ca0d2e0db
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ca308801-fef3-416e-b20a-c84652277af4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update c9b4eed5-2fd5-4aea-aae2-dfcbe6ea2b30
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 706b1166-6408-45b1-8a61-f67d0bc48f5f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit db379bca-edcc-47df-84bc-7771a604e36c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 5b5d1ba3-0f64-4997-8d02-ca135aa482d3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 4e756118-09cf-43b0-abf2-3ec52566c799
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 5fc60b0f-fca5-497d-9088-ccf8537d436a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 77d366d9-1b37-4bee-8e14-e5eaa2b32b95
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 593f8841-d9e2-4ad2-85a9-c294a2c16c08
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit a7a93518-939b-4943-8f09-1d6ef8a21400
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7e1fdf29-5178-4709-a429-96b813dfdf0d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 27e497b4-b19c-41c5-a095-4ce5980a9897
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 017905dd-1acd-46cb-85e9-cd108676ee88
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 3c92aac0-307b-41e6-a372-fd17168e23a8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 71189239-8f4c-4520-87c3-b83f769cc540
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 7590a963-0c2a-410a-bb97-c0dd0ac3bee6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 242fa3f3-adbf-416f-8fe6-2e517df2a158
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit cdc9e6dd-5a5e-4fd3-b9b3-13a2d96a876c
…

Copy link
Collaborator

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great awesome work!

@sjproctor sjproctor merged commit 946b344 into main Jan 27, 2025
9 checks passed
@sjproctor sjproctor deleted the i189-institutional-repository-carousel branch January 27, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants