-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Updates to search form overrides #2409
Conversation
This commit: - updates the search form override view files for the cultural and institutional repositories to align with existing code in Hyrax which fixes styling issues in the dropdown menus - updates the Hyku dependencies to the latest versions of Hyrax gems Ref: - notch8/palni_palci_knapsack#156
@@ -1,4 +1,4 @@ | |||
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-4 %> | |||
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-4 %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nitpicky of me, but i think this comment should be updated to v5.0.1
@@ -1,4 +1,4 @@ | |||
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-6 %> | |||
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-6 %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments are nonblocking
Test Results 3 files ±0 3 suites ±0 17m 45s ⏱️ -12s Results for commit 0f29ec6. ± Comparison against base commit 71dfcb5. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
Updated Search Form View File Overrides
Ref:
This commit:
@samvera/hyku-code-reviewers