Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Updates to search form overrides #2409

Merged
merged 2 commits into from
Jan 14, 2025
Merged

🧹 Updates to search form overrides #2409

merged 2 commits into from
Jan 14, 2025

Conversation

sjproctor
Copy link
Collaborator

Updated Search Form View File Overrides

Ref:

This commit:

  • updated the search form override view files for the Cultural and Institutional Repositories to align with existing code in Hyrax which fixed styling issues in the search form dropdown menus
  • updated the Hyku dependencies to the latest versions of Hyrax gems

@samvera/hyku-code-reviewers

This commit:
- updates the search form override view files for the cultural and
institutional repositories to align with existing code in Hyrax which
fixes styling issues in the dropdown menus
- updates the Hyku dependencies to the latest versions of Hyrax gems

Ref:
- notch8/palni_palci_knapsack#156
@sjproctor sjproctor added the patch-ver for release notes label Jan 14, 2025
@@ -1,4 +1,4 @@
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-4 %>
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-4 %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nitpicky of me, but i think this comment should be updated to v5.0.1

@@ -1,4 +1,4 @@
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-6 %>
<% # OVERRIDE: Hyrax v5.0.0rc2 template to change the size of the column on line 8 from col-sm-3 to col-sm-6 %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this one

kirkkwang
kirkkwang previously approved these changes Jan 14, 2025
Copy link
Collaborator

@kirkkwang kirkkwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are nonblocking

Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 45s ⏱️ -12s
2 055 tests ±0  1 999 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 082 runs  ±0  2 024 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 0f29ec6. ± Comparison against base commit 71dfcb5.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a6f5949f-cbf1-4fe5-8fe5-00c60a7510f6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit aa3c4e56-2608-4581-b551-2794e97a4f35
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read b4eea761-87a5-43bb-bec8-68fe792136e3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 819dea1f-2582-4164-86aa-464182c89dd2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy ab1e1b99-d3d1-4448-8d4d-8af99d1acae0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 940fe4cc-215c-4351-acf8-aa1328706b53
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read eda4c34c-34e3-4be7-833c-e3ce324c492f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d8100201-c0f2-4d19-820f-9e086f2ab0dc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy c73889f6-46ee-4c4a-b935-dc637dbd21f8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b6114df1-423b-4c63-954e-fa4692eb368a
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 494ef66d-b005-4dae-b378-d8fe983a915a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit f20062c7-cd01-45ec-bf5a-cf80645e225f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 12849753-72af-44ad-8f3e-0a06dad0c419
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 761e4e3a-2eb8-41ea-ae48-b4c08d89fe7d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 9c0861a2-5448-4286-9b07-0b4fc8e44064
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f7a1b081-c5b3-4d53-9725-e5cc6ff59eaa
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 66af405f-50ef-496c-bc7f-d884c5065b56
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update a0242697-6373-462d-b229-93536d83a85e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 8e40d626-48dd-4d30-84ac-14c80aa601a6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit f0660623-5296-4325-ada9-cbf2813a17be
…

@sjproctor sjproctor merged commit 88799ab into main Jan 14, 2025
8 checks passed
@sjproctor sjproctor deleted the i156-search-dropdown branch January 14, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants