Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Align User Collection badge #2408

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

kirkkwang
Copy link
Collaborator

Remove extra classes that throw the alignment of the badge off.

Before:
image

After:
image

Remove extra classes that throw the alignment of the badge off.
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 14, 2025
Copy link
Collaborator

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads up - main's pipeline is failing

Copy link

Test Results

    3 files  ±0      3 suites  ±0   18m 18s ⏱️ +55s
2 055 tests ±0  1 999 ✅ +1  56 💤 ±0  0 ❌  - 1 
2 082 runs  ±0  2 024 ✅ +1  58 💤 ±0  0 ❌  - 1 

Results for commit 60041c4. ± Comparison against base commit e07ca03.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 1add4594-b167-431e-90e3-104a46605ae9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit bc9eba6e-2277-407a-8a27-1f9844c27f64
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 80351bb2-e8b9-4b44-925f-d7486a11335b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 001c461a-c9cb-4a34-aafa-81b70e417ef5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 4d1ac0a5-746d-480c-868a-16db4c15e94f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 1b0857d1-1aea-44ed-af95-13ca2e066de5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read a99996f9-e5e5-4196-bf93-a70a4b9778d3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 39cc19b8-70c2-4566-8314-2bc91839af93
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 9f9a070e-bfd5-4718-ae64-06ec0fb1f69f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit cb45a7df-35a6-4ed6-915c-04f328a8d8dc
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy db4a4ba7-9043-4ee2-8d71-bf841a1d49ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 3a2e35d2-6dc3-417f-bc79-1b1a45cb8881
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 2f44e4cd-a70b-492d-b545-5f195ad571ed
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 88c4d8e7-faaf-4d97-9cef-fc50fbc7de14
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3bba1a21-e4be-49ff-9aaf-3baad0721869
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 88b86db3-5eee-4943-8991-53346ea37654
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read d17bbf0a-bf67-4f6f-a73c-5254310ae3ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 147314ec-6c06-49e4-927c-36b83beb88c7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a74da3bf-577a-42ac-a724-255349d59c5d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 4c2496cb-d125-491e-9752-b9b4d3184d0e
…

@kirkkwang kirkkwang merged commit 71dfcb5 into main Jan 14, 2025
8 of 9 checks passed
@kirkkwang kirkkwang deleted the i173-align-user-collection-badge branch January 14, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants