Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly adds dependency for benchmarkable #35

Conversation

mejackreed
Copy link

Closes #30

This explicitly requires 'activesupport-core-ext' as a dependency. Having issues in other projects where travis will report that Benchmarkable is not loaded.

NameError: uninitialized constant ActiveSupport::Benchmarkable

https://travis-ci.org/geoblacklight/geoblacklight/builds/45956482

@mejackreed
Copy link
Author

cc @atz

@jcoyne
Copy link
Contributor

jcoyne commented Jan 5, 2015

activesupport-core-ext is not compatible with activesupport. It's an either/or sort of thing.

@mejackreed
Copy link
Author

Ah ok.. ls there an explicit way then to include ActiveSupport::Benchmarkable ? This include is failing for me?

https://github.com/projecthydra/jettywrapper/blob/master/lib/jettywrapper.rb#L20

@jcoyne
Copy link
Contributor

jcoyne commented Jan 5, 2015

There's already a dependency on ActiveSupport. Try adding require 'activesupport' up on line 5? I'm surprised you see an error on line 20, because 'benchmarkable' is required on line 7. Maybe it's because you aren't using the master branch which has this commit: 92653cc

@mejackreed
Copy link
Author

👍 @jcoyne ... thanks. That seemed to solve the problem.

@mejackreed mejackreed closed this Jan 5, 2015
@mejackreed mejackreed deleted the specify-activesupport-core-ext branch January 5, 2015 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jettywrapper should explicitly require 'active_support/benchmarkable'
2 participants