Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/electron-chrome-extensions/spec/extensions-spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { expect } from 'chai'
import { session } from 'electron'
import { ElectronChromeExtensions } from '../'
import { waitForBackgroundPage } from './crx-helpers'
import { useExtensionBrowser } from './hooks'

describe('Extensions', () => {
const testSession = session.fromPartition('test-extensions')
Expand All @@ -19,4 +21,16 @@ describe('Extensions', () => {
})
}).to.throw()
})

describe('browser namespace', () => {
const browser = useExtensionBrowser({ extensionName: 'rpc' })

it('aliases browser to the patched chrome object', async () => {
const backgroundPage = await waitForBackgroundPage(browser.extension, browser.session)
const result = await backgroundPage!.executeJavaScript(
`browser === chrome && typeof browser.browserAction.setBadgeText === 'function'`,
)
expect(result).to.equal(true)
})
})
})
12 changes: 12 additions & 0 deletions packages/electron-chrome-extensions/src/renderer/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,18 @@ export const injectExtensionAPIs = () => {

Object.freeze(chrome)

// Chromium also exposes a native `browser` namespace, separate from `chrome`. Point it at the
// patched `chrome` so extensions using `browser.*` (e.g. uBlock Origin, Plasmo) get the APIs
// above. defineProperty replaces the native global whether it's a value or an accessor.
if ('browser' in globalThis) {
Object.defineProperty(globalThis, 'browser', {
value: chrome,
enumerable: true,
configurable: true,
writable: true,
})
}

void 0 // no return
}

Expand Down