Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve legibility on light-background terminals #152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlitz
Copy link

@dlitz dlitz commented Apr 19, 2024

This fixes the problem of light-gray text being rendered on a light background.

Users can now choose a different Pygments style/theme using the PY_DEVTOOLS_STYLE environment variable.

If PY_DEVTOOLS_STYLE is not set, we attempt auto-detection using the COLORFGBG environment variable, as is commonly done by some tools on Linux and macOS.

  • Dark-background terminals use the "vim" style, as before.
  • Light-background terminals now use the "sas" style.
  • If auto-detection fails, we use the "default" style, which is legible on most terminals.

A list of available styles can be obtained by running:

import pygments.styles
list(pygments.styles.get_all_styles())

Screenshots

Light background (COLORFGBG=0;15)

Before After
Screenshot_20240418_192705 Screenshot_20240418_192901

Dark background (COLORFGBG=15;0)

Before After
Screenshot_20240418_192757 Screenshot_20240418_192825

Indeterminate (COLORFGBG missing or unparsable)

Dark Background Light Background
Screenshot_20240418_193510 Screenshot_20240418_193640

@dlitz dlitz force-pushed the lightbg branch 2 times, most recently from b371fbd to 248f6c5 Compare April 19, 2024 02:21
This fixes the problem of light-gray text being rendered on a light
background.

Users can now choose a different Pygments style/theme using the
PY_DEVTOOLS_STYLE environment variable.

If PY_DEVTOOLS_STYLE is not set, we attempt auto-detection using the
COLORFGBG environment variable, as is commonly done by some tools on
Linux and macOS.

- Dark-background terminals use the "vim" style, as before.
- Light-background terminals now use the "sas" style.
- If auto-detection fails, we use the "default" style, which is legible
  on most terminals.

A list of available styles can be obtained by running:

    import pygments.styles
    list(pygments.styles.get_all_styles())
@dlitz
Copy link
Author

dlitz commented Apr 19, 2024

Fixed the commit message & CI builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant