Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Call /reader/refresh_feeds instead of forcing /reader/feeds to update counts #1871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quad
Copy link
Contributor

@quad quad commented Jun 26, 2024

This patches a long outstanding bug in 50e88b2.

This patches a long outstanding bug in 50e88b2.
@samuelclay
Copy link
Owner

@sictiru I agree with this ticket, we should do the right thing and call /reader/feeds?flat=true&refresh_counts=false and then immediately call /reader/refresh_feeds/ to get the right count. On iOS, we show a "Counting is difficult..." message. I kinda remember making this call to get Android shipped a tiny bit faster, but it means Android is slow to load. Let's get this fixed!

@samuelclay samuelclay changed the title Fix not forcing Android clients to use refresh_feeds Android: Call /reader/refresh_feeds instead of forcing /reader/feeds to update counts Nov 12, 2024
@samuelclay
Copy link
Owner

Oh, this PR isn't the way to do it. But we can keep this PR as the ticket for it for now. I'm not going to be merging this, since this is fixing it in the wrong spot, but it's helpful to have as a reference, so let's just use this as the Android ticket.

@samuelclay
Copy link
Owner

Ohh, looking more carefully at this PR (and not the commit that I mistakenly thought was this PR's code), I realize that it is doing the right thing already. Androd is the 6 letter version of Android that i use in extract_user_agent since it makes the log a bit cleaner (iPhone is 6 letters, so they take the same size).

platform = "Androd"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants