Fix tabix NULL deref on open failure and dead detect=0 code#2532
Open
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Open
Fix tabix NULL deref on open failure and dead detect=0 code#2532sirus20x6 wants to merge 1 commit intosamtools:developfrom
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Conversation
1. Move `detect = 0` outside the error else-block where it was unreachable dead code after `return 1`. It now executes when a valid -p type is matched, properly suppressing auto-detection. 2. Add a NULL check on the bgzf_open() return value in the is_all branch to avoid dereferencing a NULL pointer when the file cannot be opened.
sirus20x6
force-pushed
the
fix/tabix-fixes
branch
from
8fc8507 to
f4ccb3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bgzf_openreturn in the read-all branch — was guaranteed to crash if the file could not be openeddetect = 0from inside the errorelseblock (dead code afterreturn 1) to after the type-matching block —-ppreset was being overridden by filename auto-detectionTest plan
bcftools tabix -p bed foo.vcf.gzuses BED format, not VCF