Skip to content

Fix ccall type-punning and mcall division by zero #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sirus20x6 wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −2
Open

Fix ccall type-punning and mcall division by zero #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ccall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ static int update_bcf1(call_t *call, bcf1_t *rec, const bcf_p1rst_t *pr, double
int has_I16, is_var;
float fq, r;
anno16_t a;
float tmpf[4], tmpi;
float tmpf[4];
int32_t tmpi;

bcf_get_info_float(call->hdr, rec, "I16", &call->anno16, &call->n16);

Expand Down
3 changes: 2 additions & 1 deletion mcall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,7 +1659,8 @@ int mcall(call_t *call, bcf1_t *rec)
int32_t dp[4]; dp[0] = call->anno16[0]; dp[1] = call->anno16[1]; dp[2] = call->anno16[2]; dp[3] = call->anno16[3];
bcf_update_info_int32(call->hdr, rec, "DP4", dp, 4);

int32_t mq = (call->anno16[8]+call->anno16[10])/(call->anno16[0]+call->anno16[1]+call->anno16[2]+call->anno16[3]);
int32_t dp4_sum = call->anno16[0]+call->anno16[1]+call->anno16[2]+call->anno16[3];
int32_t mq = dp4_sum > 0 ? (call->anno16[8]+call->anno16[10])/dp4_sum : 0;
bcf_update_info_int32(call->hdr, rec, "MQ", &mq, 1);

if ( call->output_tags & CALL_FMT_PV4 )
Expand Down