Fix vcfcnv OOB read with control sample and AA skip mismatch#2529
Open
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Open
Fix vcfcnv OOB read with control sample and AA skip mismatch#2529sirus20x6 wants to merge 1 commit intosamtools:developfrom
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Conversation
- Guard control_sample parse when idx=-1 to prevent OOB read - Initialize baf2/lrr2 to safe defaults when parse is skipped - Add AA genotype skip in third loop to match first two loops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_lrr_baffor control sample whenidx=-1(no control configured) — was reading BAF/LRR at negative array offsetbaf2/lrr2to safe defaults when control sample parse is skippedbaf > 4/5.skip (AA genotypes) in the third optimization loop to match the first two loops — without it, loop counterkexceededtmpfboundsTest plan
bcftools cnvwithout control sample does not crash