Fix vcfnorm writing float missing values to wrong buffer#2522
Open
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Open
Fix vcfnorm writing float missing values to wrong buffer#2522sirus20x6 wants to merge 1 commit intosamtools:developfrom
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Conversation
The BCF_HT_REAL case in split_format_numeric called bcf_float_set_missing(src_vals[idst]) instead of bcf_float_set_missing(dst_vals[idst]), writing the missing sentinel into the source buffer rather than the destination. The int32 case on the preceding line correctly uses dst_vals[idst].
sirus20x6
force-pushed
the
fix/vcfnorm-split-format
branch
from
29a8528 to
be0b7ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split_format_numeric,bcf_float_set_missing(src_vals[idst])wrote to the source buffer instead of the destination — changed todst_vals[idst]to match the int32 case on the preceding lineTest plan