Fix wrong loop variable in family trio sample remapping#2518
Open
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Open
Fix wrong loop variable in family trio sample remapping#2518sirus20x6 wants to merge 1 commit intosamtools:developfrom
sirus20x6 wants to merge 1 commit intosamtools:developfrom
Conversation
In the family trio remapping loop, the inner loop iterates with `j` (0,1,2 for CHILD,FATHER,MOTHER) but fam->sample was indexed by `i` (the outer family loop variable) instead of `j`. This caused only the i-th sample slot to be remapped repeatedly, leaving the other two family members with stale indices.
sirus20x6
force-pushed
the
fix/vcfcall-family-index
branch
from
b15b3bd to
24ce856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iinstead of inner loop variablejwhen remapping family trio sample indices invcfcall.cj=0..2(CHILD, FATHER, MOTHER) but indexedfam->sample[i]instead offam->sample[j], corrupting family data and causing out-of-bounds access wheni >= 3Test plan
-Goption produces correct family genotype constraints