Merge pull request #15 from samsonasik/set-validation-in-track #267
samsonasikAnnotations
4 warnings
|
PHP 8.1:
src/Controllers/Album.php#L74
Escaped Mutant for Mutator "IfNegation":
--- Original
+++ New
@@ @@
if ($this->request->getMethod() === 'post') {
/** @var array $post */
$post = $this->request->getPost();
- if ($this->albumRepository->save($post)) {
+ if (!$this->albumRepository->save($post)) {
session()->setFlashdata(self::STATUS, 'New album has been added');
return redirect()->route(self::ALBUM_INDEX);
}
|
|
PHP 8.1:
src/Controllers/Track.php#L99
Escaped Mutant for Mutator "IfNegation":
--- Original
+++ New
@@ @@
/** @var array $post */
$post = $this->request->getPost();
try {
- if ($this->trackRepository->save($post)) {
+ if (!$this->trackRepository->save($post)) {
session()->setFlashdata(self::STATUS, 'New album track has been added');
return redirect()->route(self::TRACK_INDEX, [$albumId]);
}
|
|
PHP 8.1:
src/Infrastructure/Persistence/Track/SQLTrackRepository.php#L83
Escaped Mutant for Mutator "FalseValue":
--- Original
+++ New
@@ @@
// model->validate() check empty data early to run true
// which on controller test with invalid data, it bypassed
// so need to instantiate validation service with set rules here
- $validation = Services::validation(null, false);
+ $validation = Services::validation(null, true);
$isValid = $validation->setRules($this->model->getValidationRules())->run($data);
if (!$isValid) {
return false;
|
|
PHP 8.1
Unexpected input(s) 'yml', valid inputs are ['token', 'files', 'directory', 'flags', 'aws_curl_args', 'codecov_curl_args', 'commit_parent', 'env_vars', 'fail_ci_if_error', 'file', 'functionalities', 'gcov_args', 'gcov_executable', 'gcov_path_exclude', 'gcov_path_include', 'gcov_prefix', 'gcov_root_dir', 'move_coverage_to_trash', 'name', 'network_filter', 'override_branch', 'override_build', 'override_commit', 'override_pr', 'override_tag', 'path_to_write_report', 'root_dir', 'verbose', 'working-directory', 'xcode_derived_data', 'xcode_package']
|