Adding CSR Sparse Matrix Dense Vector Multiplication Benchmark #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
approved these changes
Sep 7, 2023
Pat-Lafon
reviewed
Sep 7, 2023
| free res; | ||
|
|
||
| good: int = const 0; | ||
| ret good; |
There was a problem hiding this comment.
Would you consider removing the return value of main? While I guess this hasn't been specified, afaik there isn't any implementation that will make use of this value. Most will silently ignore it like brili does.
brilirs rejects this program(I thought because of #91 but git blame predates that) which I think is fair?
Let me know what you think.
There was a problem hiding this comment.
I agree. Indeed there is no specifiction saying main shoud return a value to be used.
Shall I make a new PR for this?
There was a problem hiding this comment.
Good idea! Yes please, a new PR would be great. (I suppose we should document this, and probably add a check in brilck…)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark generates a CSR sparse matrix and a dense vector with a linear feedback shift register RNG, multiplies them, and prints the matrix, intput, and output. I have verified it against the scipy implementation of matrix-vector multiplication.