Karoke-style captions #2217
Draft
Karoke-style captions #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2214
This adds support for karoke-style captions as described here: https://developer.mozilla.org/en-US/docs/Web/API/WebVTT_API#cue_payload_text_tags
These are used by YouTube auto-generated captions. Currently you can only make the "future text" translucent, not hide it (well you can set the opacity to 0% but the background is still there) but that's what Chrome does anyway. by default at least.
At the moment the code is a bit of a mess, I'm going to clean it up