Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper WebVTT timing support #2214

Open
Heath123 opened this issue May 20, 2021 · 3 comments · May be fixed by #2217
Open

Proper WebVTT timing support #2214

Heath123 opened this issue May 20, 2021 · 3 comments · May be fixed by #2217

Comments

@Heath123
Copy link

Heath123 commented May 20, 2021 •
edited
Loading

WebVTT supports displaying captions with timings that display one word at a time, which YouTube auto-generated subtitles use:

00:00:02.159 --> 00:00:03.350 align:start position:0%
okay so i received this exciting email
which<00:00:02.399><c> reads</c><00:00:02.879><c> hello</c>

Plyr doesn't support this, instead doing this:
image
Here's an example from this video.
What Plyr does now is sort of hard to read
@Heath123
Copy link
Author

The example above is Firefox, Chrome is similar but with an extra question mark
image

@Heath123
Copy link
Author

OK, this is a ProcessingInstruction

@Heath123
Copy link
Author

I have this working now but in a really hacky way, I'll try to clean it up and PR it

@Heath123 Heath123 linked a pull request May 21, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Karoke-style captions Heath123/plyr
1 participant
@Heath123