Skip to content

Conversation

@timakro
Copy link
Collaborator

@timakro timakro commented Oct 22, 2025

Prevents:

  • us from removing stuff from the apps object
  • the app from internally mutating the options after setOptions

Copy link
Collaborator

@patrickskowronekdkfz patrickskowronekdkfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why this would make sense, but we would override the current options/catalogue regardless of the correctness.

@timakro
Copy link
Collaborator Author

timakro commented Oct 24, 2025

Already before this PR the validation was only showing a warning and not stopping the options/catalogue from being loaded. At some point in the past we made this change from error to warning because it was annoying during development to not be able to test stuff just because the schema doesn't 100% match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants