feat(option): fixed sematic issue in option type and adapted omitzero tag
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiyo5hi
force-pushed
the
kiyoshi.guo/json-marshal
branch
from
90da63c to
70fcaa4
Compare
Kiyo5hi
force-pushed
the
kiyoshi.guo/json-marshal
branch
from
70fcaa4 to
a5c4278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, especially with the
omitemptytag, there has been a semantic issue with theOptiontype: whether a user omitted a field or set it tonullmanually,isPresentwould be set tofalse.This introduced ambiguity similar to a raw pointer in Go since we couldn't differentiate between these two scenarios.
With the introduction of
omitzeroin Go 1.24, this problem can be completely resolved.Options withisPresentset tofalseare dropped, indicating "I do not want to touch this value."isPresentset totrue, indicating "I do want to touch this value."