Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DifferenceBy for slices with any types #456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yesmishgan
Copy link

This request contains a new function to find the difference between two slices consisting of any elements using the callback function

@yesmishgan yesmishgan changed the title Feature/difference Add DifferenceBy for slices with any types May 18, 2024
@yesmishgan
Copy link
Author

Hi, can you review it @samber ?

@miles-ton
Copy link

this looks useful

@yesmishgan
Copy link
Author

thank you! but i can't merge without @samber 's code review

@takanuva15
Copy link

takanuva15 commented Aug 12, 2024

Note this completes part of the request under #411

@druvv
Copy link

druvv commented Aug 20, 2024

I would really appreciate this functionality being built into lo!

@takanuva15
Copy link

@samber Seems this PR is a highly requested feature; there is already another duplicate PR just like this one here: https://github.com/samber/lo/pull/426/files

@takanuva15
Copy link

Did some more research and I realized there is another library with a massive slice util library, that includes this DifferenceBy function along with UnionBy. Worth a look:
https://github.com/duke-git/lancet?tab=readme-ov-file#-18-slice-contains-some-functions-to-manipulate-slice----index

@yesmishgan
Copy link
Author

@samber Hello! Can you review it? I want to contribute it and use in my projects to improve usability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants