Skip to content

Conversation

@nikhil-sethi
Copy link
Collaborator

Description

We want to use the snp_motion_planning/src/tasks headers in external repositories. So we need to expose this repository as a library and let the client code use the headers from the include folder.

Changes

  • Headers were moved to an include folder
  • References to header files were updated accordingly in the source files.
  • CMakeLists.txt was updated to link properly and only expose the _tasks

Testing

To include the headers and library in your ROS2 client package do the following in the CMakeLists:

find_package(snp_motion_planning REQUIRED)
find_package(tesseract_kinematics REQUIRED)
...

set(dependencies
..
snp_motion_planning
)

...
target_link_libraries(${PROJECT_NAME}
...
...
  snp_motion_planning::snp_motion_planning_tasks
)

@nikhil-sethi nikhil-sethi self-assigned this Sep 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch expose_plugins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nikhil-sethi nikhil-sethi changed the title Expose plugins use snp_motion_planning as a librrary Expose plugins use snp_motion_planning as a library Sep 17, 2025
@nikhil-sethi nikhil-sethi changed the title Expose plugins use snp_motion_planning as a library Expose plugins to use snp_motion_planning as a library Sep 17, 2025
@dave992 dave992 requested review from gavanderhoorn and removed request for dave992 October 1, 2025 06:42
@gavanderhoorn
Copy link
Member

Would it not have been sufficient to update/change the install(..) statement without moving the headers? Would result in a smaller changeset and easier to maintain.

@nikhil-sethi
Copy link
Collaborator Author

Would it not have been sufficient to update/change the install(..) statement without moving the headers? Would result in a smaller changeset and easier to maintain.

I don't know how to do that. I'm just following standard cpp/ROS convention of keeping header files in an include folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants