Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update emotion support (MUI latest version) and add support for Node with ESM #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/support-yarn2-pnp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
"lz-string": "^1.4.4",
"pnp-webpack-plugin": "^1.6.4",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"urlsafe-base64": "^1.0.0"
"react-dom": "^16.13.1"
},
"installConfig": {
"pnp": true
Expand Down
4 changes: 1 addition & 3 deletions packages/core/lib/webpack/antd.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import React from 'react';
import ReactDOM from 'react-dom';
import LZString from 'lz-string';
import URLSafeBase64 from 'urlsafe-base64';
import App from '__REACT_SSR_APP__';
import Page from '__REACT_SSR_PAGE__';

const getProps = () => {
const compressedProps = document.getElementById('react-ssr-script').dataset.props;
const decoded = URLSafeBase64.decode(compressedProps);
const decompressed = LZString.decompressFromUint8Array(decoded);
const decompressed = LZString.decompressFromBase64(compressedProps);
return JSON.parse(decompressed);
}

Expand Down
4 changes: 1 addition & 3 deletions packages/core/lib/webpack/default.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import React from 'react';
import ReactDOM from 'react-dom';
import LZString from 'lz-string';
import URLSafeBase64 from 'urlsafe-base64';
import App from '__REACT_SSR_APP__';
import Page from '__REACT_SSR_PAGE__';

const getProps = () => {
const compressedProps = document.getElementById('react-ssr-script').dataset.props;
const decoded = URLSafeBase64.decode(compressedProps);
const decompressed = LZString.decompressFromUint8Array(decoded);
const decompressed = LZString.decompressFromBase64(compressedProps);
return JSON.parse(decompressed);
}

Expand Down
8 changes: 3 additions & 5 deletions packages/core/lib/webpack/emotion.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
import React from 'react';
import ReactDOM from 'react-dom';
import { CacheProvider } from '@emotion/core';
import { CacheProvider } from '@emotion/react';
import createCache from '@emotion/cache';
import LZString from 'lz-string';
import URLSafeBase64 from 'urlsafe-base64';
import App from '__REACT_SSR_APP__';
import Page from '__REACT_SSR_PAGE__';

const getProps = () => {
const compressedProps = document.getElementById('react-ssr-script').dataset.props;
const decoded = URLSafeBase64.decode(compressedProps);
const decompressed = LZString.decompressFromUint8Array(decoded);
const decompressed = LZString.decompressFromBase64(compressedProps);
return JSON.parse(decompressed);
}

const cache = createCache();
const cache = createCache({ key: "react-ssr" });

ReactDOM.render(
<CacheProvider value={cache}>
Expand Down
4 changes: 1 addition & 3 deletions packages/core/lib/webpack/material-ui.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import React from 'react';
import ReactDOM from 'react-dom';
import LZString from 'lz-string';
import URLSafeBase64 from 'urlsafe-base64';
import App from '__REACT_SSR_APP__';
import Page from '__REACT_SSR_PAGE__';

const getProps = () => {
const compressedProps = document.getElementById('react-ssr-script').dataset.props;
const decoded = URLSafeBase64.decode(compressedProps);
const decompressed = LZString.decompressFromUint8Array(decoded);
const decompressed = LZString.decompressFromBase64(compressedProps);
return JSON.parse(decompressed);
}

Expand Down
4 changes: 1 addition & 3 deletions packages/core/lib/webpack/styled-components.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import React from 'react';
import ReactDOM from 'react-dom';
import LZString from 'lz-string';
import URLSafeBase64 from 'urlsafe-base64';
import App from '__REACT_SSR_APP__';
import Page from '__REACT_SSR_PAGE__';

const getProps = () => {
const compressedProps = document.getElementById('react-ssr-script').dataset.props;
const decoded = URLSafeBase64.decode(compressedProps);
const decompressed = LZString.decompressFromUint8Array(decoded);
const decompressed = LZString.decompressFromBase64(compressedProps);
return JSON.parse(decompressed);
}

Expand Down
2 changes: 0 additions & 2 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"slash": "3.0.0",
"terser-webpack-plugin": "5.3.6",
"unionfs": "4.4.0",
"urlsafe-base64": "1.0.0",
"webpack": "5.74.0",
"webpack-dev-server": "4.10.1",
"webpack-merge": "5.8.0"
Expand All @@ -81,7 +80,6 @@
"@types/react": "^18.0.18",
"@types/react-dom": "^18.0.6",
"@types/recursive-readdir": "^2.2.1",
"@types/urlsafe-base64": "^1.0.28",
"@types/webpack": "^5.28.0",
"cross-env": "^7.0.3",
"express": "^4.18.1",
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@ const getSsrConfig = (): Config => {
staticViews: [],
};
const ssrConfigPath = path.join(cwd, 'ssr.config.js');
const ssrConfigCjsPath = path.join(cwd, 'ssr.config.cjs');
if (existsSync(ssrConfigPath)) {
return Object.assign(defaultConfig, require(ssrConfigPath));
} else if (existsSync(ssrConfigCjsPath)) {
return Object.assign(defaultConfig, require(ssrConfigCjsPath));
} else {
return defaultConfig;
}
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/optimize/webpack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const prodConfig: webpack.Configuration = {
plugins: [
new webpack.DefinePlugin({
'process.env.NODE_ENV': JSON.stringify('production'),
'process.env.REACT_SSR_ENV': JSON.stringify('production'),
}),
],
};
Expand Down
4 changes: 1 addition & 3 deletions packages/core/src/render/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import path from 'path';
import React from 'react';
import slash from 'slash';
import LZString from 'lz-string';
import URLSafeBase64 from 'urlsafe-base64';
import App from '../components/App';
import Document from '../components/Document';
import {
Expand Down Expand Up @@ -96,8 +95,7 @@ const getRenderToStringMethod = async () => {

const compressProps = (props: any) => {
const packed = JSON.stringify(props);
const compressed = Buffer.from(LZString.compressToUint8Array(packed));
return URLSafeBase64.encode(compressed);
return LZString.compressToBase64(packed);
}

export default async function render(file: string, props: any): Promise<string> {
Expand Down
6 changes: 3 additions & 3 deletions packages/core/src/render/stringify/emotion.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ import {

const Head = require('./head');

const { CacheProvider } = require('@emotion/core');
const { CacheProvider } = require('@emotion/react');
const emotionCache = require('@emotion/cache');
const emotionServer = require('create-emotion-server');
const emotionServer = require('@emotion/server/create-instance');
const createCache = emotionCache.default || emotionCache;
const createEmotionServer = emotionServer.default || emotionServer;
const cache = createCache();
const cache = createCache({ key: "react-ssr" });
const { extractCritical } = createEmotionServer(cache);

export default (app: React.ReactElement, pageId: string, props: string) => {
Expand Down
14 changes: 0 additions & 14 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.