-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salt-ssh can deploy a relenv environment #66878
Merged
Merged
+286
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Salt-ssh can deploy a relenv environment
[master] Salt-ssh can deploy a relenv environment
Sep 10, 2024
Akm0d
changed the title
[master] Salt-ssh can deploy a relenv environment
[draft] Salt-ssh can deploy a relenv environment
Sep 10, 2024
dmurphy18
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the changelog entry, and tests.
twangboy
requested changes
Sep 23, 2024
twangboy
approved these changes
Sep 23, 2024
dmurphy18
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new
--relenv
option tosalt-ssh
that deploys a relenv (onedir) bundled version of Salt and Python on the SSH target. The--relenv
option works similarly to--thin
but deploys a bundled Salt environment for cases where it’s preferable to use relenv.What issues does this PR fix or reference?
Fixes #66877
Previous Behavior
Salt-ssh
only supported the--thin
option, which deploys a minimal Salt environment.New Behavior
The new
--relenv
option allowssalt-ssh
to deploy a full Salt environment bundled with Python, offering more flexibility in environments where relenv is preferable. This will eventually become the new default, but for now, it remains an option.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes