Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr548 updated #550

Closed
wants to merge 3 commits into from
Closed

Conversation

lmf-mx
Copy link

@lmf-mx lmf-mx commented Jun 16, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#548
#545
#539

Describe the changes you're proposing

Updates #548

  • Cover correct key choices depending on version, including edge cases for jammy and RHEL9
  • Sets arch path in repository to match osarch directly, x86_64 is not used in Debian repo definitions
  • Additions are able to be stripped out as repository stops supporting older cases without impact
  • Defaults to onedir for 3005, but allows for pillar override to classic where possible

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@lmf-mx lmf-mx requested a review from a team as a code owner June 16, 2023 06:19
@lmf-mx lmf-mx mentioned this pull request Jun 21, 2023
19 tasks
@lmf-mx
Copy link
Author

lmf-mx commented Jul 26, 2023

Closing in favor or new clean PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants