Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set arbitrary log options in global #50

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

hoonetorg
Copy link
Contributor

No description provided.

@@ -23,8 +23,14 @@
# Global settings
#------------------
global
{%- if salt['pillar.get']('haproxy:global:log', []) != [] %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just iterate over salt['pillar.get']('haproxy:global:log', []) directly here. If it is empty there is nothing to iterate over.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BABILEN: good catch if there wasn't the 'else' ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, might make sense to use those entries as default then.

@hoonetorg
Copy link
Contributor Author

@BABILEN:
having such an else could be omitted, if there would be a defaults.yaml/map.jinja as I discussed with @johnkeates here #48.
That would be a larger change.

@kyrias
Copy link

kyrias commented May 19, 2017

Ping?

@johnkeates
Copy link
Contributor

Would be great if me or some other top contributor could actually manage this repo for PR/issues..

@gtmanfred
Copy link

@johnkeates i have added you to the maintainers list.

Thanks for helping out!
Daniel

@johnkeates
Copy link
Contributor

@gtmanfred Thanks, I'll help out where I can! Starting with the formulas I'm familiar with, of course...

Quick question: some formulas seem to be 'forked' from their upstreams, while others are copies and have no matched upstream. If there any rule/reason behind this?

@gtmanfred
Copy link

Usually we just fork it from whoever initially created it.

The ones that aren't forked were created directly in the formulas afaik.

There is no hard and fast rule about it, if people want to transfer the formula over to the repo, i don't see a problem with that.

@kyrias
Copy link

kyrias commented Aug 23, 2017

@johnkeates Ping? :p

@johnkeates johnkeates merged commit 40c7ac8 into saltstack-formulas:master Aug 25, 2017
@johnkeates
Copy link
Contributor

johnkeates commented Aug 25, 2017

@kyrias pong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants