-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to set arbitrary log options in global #50
allow to set arbitrary log options in global #50
Conversation
@@ -23,8 +23,14 @@ | |||
# Global settings | |||
#------------------ | |||
global | |||
{%- if salt['pillar.get']('haproxy:global:log', []) != [] %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just iterate over salt['pillar.get']('haproxy:global:log', [])
directly here. If it is empty there is nothing to iterate over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BABILEN: good catch if there wasn't the 'else' ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, might make sense to use those entries as default then.
@BABILEN: |
Ping? |
Would be great if me or some other top contributor could actually manage this repo for PR/issues.. |
@johnkeates i have added you to the maintainers list. Thanks for helping out! |
@gtmanfred Thanks, I'll help out where I can! Starting with the formulas I'm familiar with, of course... Quick question: some formulas seem to be 'forked' from their upstreams, while others are copies and have no matched upstream. If there any rule/reason behind this? |
Usually we just fork it from whoever initially created it. The ones that aren't forked were created directly in the formulas afaik. There is no hard and fast rule about it, if people want to transfer the formula over to the repo, i don't see a problem with that. |
@johnkeates Ping? :p |
@kyrias pong! |
No description provided.