Salt-formula-maas improvments #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAAS allow specifying multiple pxe mac addresses for a machine during machine creation. This commit makes it possible to specify the mac addresses that the server may use during pxe boot as a list in the pillar data. To be able to pass multiple mac addresses via the API, the way of creating the multipart message in the REST POST call had to be changed too. The old logic took key-value pairs assuming the value is scalar. This commit changes this logic to accept list values and in that case create multiple message parts with the same name. Due to alowing multiple mac addresses, the logic in the machine update had to be changed too. The old logic checked if the new single mac address is among the mac addresses that the host has. The new logic checks if there is intersection between the new mac addresses and the ones the machine has. If intersection found, that is used as new mac addresses, and forces recreation of the machine only if no intersection is found. Change-Id: I9f0bb5d1654f638ad5c09ce355699c2eb37f3404
alexz-kh
reviewed
Sep 5, 2018
_modules/maas.py
Outdated
| data = { | ||
| 'name': name, | ||
| 'name': fabric_name, |
There was a problem hiding this comment.
This is outdated module part. Please use new one :
https://github.com/salt-formulas/salt-formula-maas/blob/master/_modules/maasng.py#L960
Which calls' from
https://github.com/salt-formulas/salt-formula-maas/blob/master/_states/maasng.py#L584
<
https://github.com/salt-formulas/salt-formula-maas/blob/master/maas/region.sls#L299-L310
where such logic already exist
{%- for _, fabric in region.fabrics.iteritems() %}
{% set fabric_name=fabric.get('name', _) %}
There was a problem hiding this comment.
Hello,
thank you for the review.
I've dropped the "name attribute" commit, because as you mentioned the logic is already placed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request contains one improvement for maas salt formula: