Support RedHat Family #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpytloun
requested changes
Nov 27, 2018
| @@ -1,6 +1,9 @@ | |||
|
|
|||
| {%- if pillar.grafana is defined %} | |||
| include: | |||
| {%- if grains['os_family'] == 'RedHat' %} | |||
| - grafana.repo.redhat | |||
There was a problem hiding this comment.
You should not setup repositories in formulas directly.
Repositories should be controlled by pillar and enforced by linux.system.repo state.
The reasoning is that one can use any repository to provide grafana package (eg. custom mirror, etc.) not only upstream one.
|
Hi, In most of the formulas I can find on salt-formulas, by default the official repository of the software/middleware is configured but you can disable it or change it via pillar. (MySQL, Nginx, Epel, Rundeck, Foreman, Varnish) So I propose to add Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support RedHat Family