Do manual trait upcasting instead of downcasting #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #922 will degrade performances by 5.49%Comparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-tsxunswownmm
branch
3 times, most recently
from
f7d13a9 to
2073e08
Compare
Veykril
force-pushed
the
veykril/push-tsxunswownmm
branch
from
2073e08 to
28acf8c
Compare
|
Benchmarks look fairly noisy again to me |
|
Not sure, 5% is a bit more than usual. |
|
Well the increase seems to stem from ingredient fetching which means its likely the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes occurences of
dyn Databaseinternally where only the zalsas are needed for (hopefully) a perf increase. It's also an attempt at disconnecting theAnytrait from things a bit for a future change I wanna explore