Replace ThreadId usages with ZalsaLocalid
#870
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #870 will not alter performanceComparing Summary
|
Veykril
approved these changes
May 22, 2025
|
|
||
| #[derive(Debug, Default)] | ||
| pub(super) struct DependencyGraph { | ||
| /// A `(K -> V)` pair in this map indicates that the runtime | ||
| /// `K` is blocked on some query executing in the runtime `V`. | ||
| /// This encodes a graph that must be acyclic (or else deadlock | ||
| /// will result). | ||
| edges: FxHashMap<ThreadId, edge::Edge>, | ||
| edges: FxHashMap<ZalsaLocalId, edge::Edge>, | ||
|
|
||
| /// Encodes the `ThreadId` that are blocked waiting for the result |
There was a problem hiding this comment.
Suggested change
| /// Encodes the `ThreadId` that are blocked waiting for the result | |
| /// Encodes the `ZalsaLocalId` that are blocked waiting for the result |
|
Another alternative here would be to store the |
Then we would need to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment if this helps with performance. I may also need this to enforce a strict ordering between different threads that all run the same fixpoint iteration (
ThreadId::as_u64is nightly)