shrink_to_fit IdentityMap before storing it
#816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #816 will not alter performanceComparing Summary
|
Veykril
force-pushed
the
veykril/push-owxlvpvmzzmn
branch
from
327f336 to
1ac896e
Compare
MichaReiser
approved these changes
May 26, 2025
src/function/execute.rs
Outdated
| @@ -105,6 +105,7 @@ where | |||
| // outputs and update the tracked struct IDs for seeding the next revision. | |||
| self.diff_outputs(zalsa, database_key_index, old_memo, &mut revisions); | |||
| } | |||
| revisions.tracked_struct_ids.shrink_to_fit(); | |||
There was a problem hiding this comment.
Should we move this call to Memo::new? It would then also apply for memos participating in cycles
There was a problem hiding this comment.
I wasn't sure if we want to. Since some of the cycle memos are only temporary, and so doing that isn't necessarily useful (it may incur extra unnecessary re-allocations)
There was a problem hiding this comment.
This only applies to cycle heads (not queries participating in a cycle) and every cycle is very expensive anyway.
Veykril
force-pushed
the
veykril/push-owxlvpvmzzmn
branch
from
1ac896e to
b5e194d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable we do not do this for cycles, given there the memo is likely temporary anyways